Skip to content

Optionally use frontend inputs if provided#2

Open
hinshun wants to merge 1 commit into
tonistiigi:masterfrom
hinshun:frontend-inputs
Open

Optionally use frontend inputs if provided#2
hinshun wants to merge 1 commit into
tonistiigi:masterfrom
hinshun:frontend-inputs

Conversation

@hinshun
Copy link
Copy Markdown

@hinshun hinshun commented Jan 27, 2020

Depends on: moby/buildkit#1290

  • Migrate to go modules
  • Update to new ExportEntry API
  • Optionally use frontend inputs

Signed-off-by: Edgar Lee <edgarl@netflix.com>
@hinshun
Copy link
Copy Markdown
Author

hinshun commented Jan 27, 2020

Using frontend inputs:

[+] Building 52.5s (12/12) FINISHED
 => docker-image://docker.io/hinshun/pack:latest                                                                                                                                                                                                                                                                                                  1.8s
 => => resolve docker.io/hinshun/pack:latest                                                                                                                                                                                                                                                                                                      1.0s
 => => sha256:35fbfde1e69df646b751ccab6b6633b0ad4eea17c85affbb5f960e059be48256 527B / 527B                                                                                                                                                                                                                                                        0.0s
 => => sha256:0b5847db36f6804492ae01b480f4f5ba2f381aeddb7bb2faebd45300412539ea 8.21MB / 8.21MB                                                                                                                                                                                                                                                    1.6s
 => => sha256:96a21d0bb6db329cc82219f15ce3a2185689fa8c481ee6cfc505c320e815f884 591B / 591B                                                                                                                                                                                                                                                        0.0s
 => => unpacking docker.io/hinshun/pack:latest                                                                                                                                                                                                                                                                                                    0.3s
 => build                                                                                                                                                                                                                                                                                                                                        50.5s
 => local://s6bkc3103dzb94v17njomi3z4                                                                                                                                                                                                                                                                                                             0.2s
 => => transferring s6bkc3103dzb94v17njomi3z4: 2.32kB                                                                                                                                                                                                                                                                                             0.2s
 => resolve image config for docker.io/packs/cflinuxfs2:build                                                                                                                                                                                                                                                                                     1.2s
 => resolve image config for docker.io/packs/cflinuxfs2:run                                                                                                                                                                                                                                                                                       2.4s
 => local://n9o0ze1q5fuemt9utn3gfqb3q                                                                                                                                                                                                                                                                                                             0.3s
 => => transferring n9o0ze1q5fuemt9utn3gfqb3q: 2.32kB                                                                                                                                                                                                                                                                                             0.3s
 => docker-image://docker.io/library/alpine:latest                                                                                                                                                                                                                                                                                                1.3s
 => => resolve docker.io/library/alpine:latest                                                                                                                                                                                                                                                                                                    0.6s
 => => sha256:c9b1b535fdd91a9855fb7f82348177e5f019329a58c53c47272962dd60f71fc9 2.80MB / 2.80MB                                                                                                                                                                                                                                                    0.4s
 => => sha256:e7d92cdc71feacf90708cb59182d0df1b911f8ae022d29e8e95d75ca6a99776a 1.51kB / 1.51kB                                                                                                                                                                                                                                                    0.0s
 => => sha256:ab00606a42621fb68f2ed6ad3c88be54397f981a7b70a79db3d1172b11c4367d 1.64kB / 1.64kB                                                                                                                                                                                                                                                    0.0s
 => => sha256:ddba4d27a7ffc3f86dd6c2f92041af252a1f23a8e742c90e6e1297bfa1bc0c45 528B / 528B                                                                                                                                                                                                                                                        0.0s
 => => unpacking docker.io/library/alpine:latest                                                                                                                                                                                                                                                                                                  0.9s
 => docker-image://docker.io/packs/cflinuxfs2:build                                                                                                                                                                                                                                                                                              27.0s
 => => resolve docker.io/packs/cflinuxfs2:build                                                                                                                                                                                                                                                                                                   0.3s
 => => sha256:a5733e6358eec8957e81b1eb93d48ef94d649d65c69a6b1ac49f616a34a74ac1 8.91MB / 8.91MB                                                                                                                                                                                                                                                    0.9s
 => => sha256:1124eb40dd68654b8ca8f5d9ec7e439988a4be752a58c8f4e06d60ab1589abdb 10.44MB / 10.44MB                                                                                                                                                                                                                                                  0.9s
 => => sha256:21324a9f04e76c93078f3a782e3198d2dded46e4ec77958ddd64f701aecb69c0 98B / 98B                                                                                                                                                                                                                                                          0.6s
 => => sha256:6be38da025345ffb57d1ddfcdc5a2bc052be5b9491825f648b49913d51e41acb 297.29MB / 297.29MB                                                                                                                                                                                                                                               11.7s
 => => sha256:4c592fb599f727d91692fb8d34d7fafc370330444c947ffc5390e495c15e194a 1.37kB / 1.37kB                                                                                                                                                                                                                                                    0.0s
 => => sha256:395c3bc578a97659b4af4ff8ad0038836d73583be5ca12aca961473bbfb8546a 28.11MB / 28.11MB                                                                                                                                                                                                                                                  2.1s
 => => sha256:580d844e1809548ad2c2d03214a33d9780632bfdb55e3288ce6c2882a573e5a8 9.34kB / 9.34kB                                                                                                                                                                                                                                                    0.0s
 => => unpacking docker.io/packs/cflinuxfs2:build                                                                                                                                                                                                                                                                                                15.3s
 => docker-image://docker.io/packs/cflinuxfs2:run                                                                                                                                                                                                                                                                                                24.5s
 => => resolve docker.io/packs/cflinuxfs2:run                                                                                                                                                                                                                                                                                                     0.1s
 => => sha256:21324a9f04e76c93078f3a782e3198d2dded46e4ec77958ddd64f701aecb69c0 98B / 98B                                                                                                                                                                                                                                                          0.0s
 => => sha256:6be38da025345ffb57d1ddfcdc5a2bc052be5b9491825f648b49913d51e41acb 297.29MB / 297.29MB                                                                                                                                                                                                                                               10.3s
 => => sha256:f6122196a060c1b1bd1923a350f58a486d28612b85e19b5202ee68307aad7047 2.92kB / 2.92kB                                                                                                                                                                                                                                                    0.0s
 => => sha256:1124eb40dd68654b8ca8f5d9ec7e439988a4be752a58c8f4e06d60ab1589abdb 10.44MB / 10.44MB                                                                                                                                                                                                                                                  0.0s
 => => sha256:a5733e6358eec8957e81b1eb93d48ef94d649d65c69a6b1ac49f616a34a74ac1 8.91MB / 8.91MB                                                                                                                                                                                                                                                    0.0s
 => => sha256:93c30f284783887bb94d8579199ffae9509e9c64ba844349593ea82f0841d07f 1.16kB / 1.16kB                                                                                                                                                                                                                                                    0.0s
 => => unpacking docker.io/packs/cflinuxfs2:run                                                                                                                                                                                                                                                                                                  13.1s
 => apk add --no-cache jq                                                                                                                                                                                                                                                                                                                         0.8s
 => /packs/builder -buildpacksDir /var/lib/buildpacks  -outputDroplet /out/droplet.tgz -outputMetadata /out/result.json -skipDetect=false -buildpackOrder=python_buildpack                                                                                                                                                                       18.8s
 => copy droplet to stack                                                                                                                                                                                                                                                                                                                         2.0s

Comment thread build.go
}

inputManifest, ok := inputs[InputNameManifest]
if ok {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if either of these cases, if input is not found it should default to llb.Local. Even if CapFrontendInputs is supported.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hinshun looks like this needs addressing if you still want to get this merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants